Repository navigation
Update description of highdicom match_geometry parameter - #196
Merged
Merged
Conversation
fedorov
approved these changes
Nov 13, 2026
Member
|
HF card is now updated too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After finding that the default settings of highdicom's Volume.match_geometry() method were too tight and conflated multiple concepts (positional tolerance, angular tolerance), it was deprecated in highdicom 0.29.0 (ImagingDataCommons/highdicom#517), just released. If you use it now, you will get a warning telling you to update to the newer parameters
Now I am going around and removing references to it that I have left around the internet, this being one of them. The new default parameters work on the case in the notebook, so I simply remove references to it completely.